feat: use Table in devtron, argo & flux listings#996
Merged
Conversation
whoami-amrit
requested review from
vikramdevtron and
vivek-devtron
as code owners
There was a problem hiding this comment.
Pull request overview
This PR adds expandable rows functionality to the generic table component, allowing rows to have nested child rows that can be expanded or collapsed on demand.
Key Changes:
- Type definitions extended to support expandable and expanded row types with ID constraints
- State management for tracking which rows are expanded
- Toggle functionality for individual rows and "expand/collapse all" feature
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 11 comments.
| File | Description |
|---|---|
| src/Shared/Components/Table/types.ts | Refactored row types to support expandable rows with new ExpandedRowType and modified RowType to include optional expandableRows array; added isExpandedRow and isRowInExpandState props to CellComponentProps |
| src/Shared/Components/Table/styles.scss | Added styling for expanded rows with distinct background color and an unused __expanse class |
| src/Shared/Components/Table/TableContent.tsx | Implemented expand/collapse logic with state management, rendering of expand buttons, filtering visible rows to include expanded children, and grid template adjustments for expand column |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…-fe-common-lib into feat/app-list-table
13 tasks
AbhishekA1509
previously approved these changes
Jan 13, 2026
whoami-amrit
changed the title
vivek-devtron
previously approved these changes
Jan 20, 2026
added 2 commits
January 20, 2026 11:05
…-fe-common-lib into feat/app-list-table
vivek-devtron
approved these changes
Jan 20, 2026
AbhishekA1509
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for expandable rows in table. Taking in the expanded row data from user in RowType itself.
The expanded rows are like ordinary rows itself. To custom style these differently than normal cells, we can use the
isExpandedRowfield in CellComponent props. Similarly if we want to style the row that expands we can use theisRowInExpandedStateprop of CellComponent